Skip to content

fix: add GithubIcon 'w' and 'h' props #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add GithubIcon 'w' and 'h' props #46

wants to merge 1 commit into from

Conversation

jt-ziolo
Copy link

On line 68 of [path].js:

<GithubIcon w={24} h={24} />

the props w and h are excluded from the definition of GithubIcon (lines 229 - 244 of Icons.js):

export function GithubIcon() { // should be GithubIcon({ w, h })
  return (
    <svg
      xmlns="http://www.w3.org/2000/svg"
      width="24" // should be {w}
      height="24" // should be {h}
      fill="none"
      viewBox="0 0 24 24"
    >
      <path
	// ...
	></path>
    </svg>
  );
}

@jt-ziolo
fix: add GithubIcon 'w' and 'h' props
1f11282 
Fixed the following issue:
On line 68 of [path].js, the props ``w`` and ``h`` are passed into GithubIcon, but these props are excluded from the definition of GithubIcon (lines 229 - 244 of Icons.js).
@jt-ziolo jt-ziolo marked this pull request as ready for review June 29, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jt-ziolo